Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16202 fix mapit button for internationalized decimal seperator #16270

Merged
merged 3 commits into from
May 29, 2024

Conversation

arthanson
Copy link
Collaborator

Fixes: #16202

Used a filter function to get DECIMAL_SEPARATOR from Django as it could be something other then a comma.

@arthanson arthanson marked this pull request as ready for review May 23, 2024 22:07
@arthanson arthanson requested a review from jeremystretch May 23, 2024 22:08
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to use Django's stock unlocalize() template filter here?

@arthanson arthanson requested a review from jeremystretch May 28, 2024 16:32
@jeremystretch jeremystretch merged commit 4d924a9 into develop May 29, 2024
6 checks passed
@jeremystretch jeremystretch deleted the 16202-mapit branch May 29, 2024 14:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Map It Button Link is broken when used a foreign language that uses comma as decimal separator
2 participants