15873 - Make Cluster resource counters more readable #15900
Conversation
…e according to unit informed. Changed "get_extra_context" method from "ClusterView" to use the method above and convert all the disks and memories from VMs to normalize the units.
There was a problem hiding this comment.
I really think we just need to make some small adjustments to the existing humanize_megabytes() function to address the goals of #15873.
Changed humanize_megabytes in helpers.py
Changed humanize_megabytes in helpers.py
|
I was analyzing it, and there is no point in trying to convert and predict any incorrect input from the customer. I think we should talk about it. I changed "humanize_megabytes" to convert non-divisible values to 1024 in this commit and reverted all previous changes.
|
jeremystretch
requested review from
arthanson
and removed request for
jeremystretch
|
@arthanson I'll leave to this to you for review. |
There was a problem hiding this comment.
@Julio-Oliveira-Encora I think we should also make the same change to the virtual machine detail page to make it consistent
|
@arthanson, should we also do the same for the disk? |
|
actually never-mind about the disk, there is a 4.1 issue #14692 where we need to change the data-field anyways, so will do it there. |
Fixes: #15873
One method was created to normalize the VM's disk and memory sizes according to their units. That method is applied when the "Allocated Resources" is generated.