Limit inherited contacts to model

netbox-community · Feb 21, 2025 · ca6b686 · ca6b686
1 parent 72adda1
commit ca6b686
Showing 1 changed file with 8 additions and 10 deletions.
diff --git a/netbox/netbox/models/features.py b/netbox/netbox/models/features.py
@@ -373,16 +373,14 @@ def get_contacts(self, inherited=True):
         from tenancy.models import ContactAssignment
         from . import NestedGroupModel
 
-        filter = Q()
-        for obj in [self]:
-            filter |= Q(
-                object_type=ObjectType.objects.get_for_model(obj),
-                object_id__in=(
-                    obj.get_ancestors(include_self=True).values_list('pk', flat=True)
-                    if (isinstance(obj, NestedGroupModel) and inherited)
-                    else [obj.pk]
-                ),
-            )
+        filter = Q(
+            object_type=ObjectType.objects.get_for_model(self),
+            object_id__in=(
+                self.get_ancestors(include_self=True).values_list('pk', flat=True)
+                if (isinstance(self, NestedGroupModel) and inherited)
+                else [self.pk]
+            ),
+        )
 
         return ContactAssignment.objects.filter(filter)