Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with integrate_odes() for numeric solver #1147

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

pnbabu
Copy link
Contributor

@pnbabu pnbabu commented Dec 9, 2024

This PR solves a bug for neuron models with higher-order differential equations and a numeric solver where not all the state variables of the higher-order ODEs were solved by the GSL solver.

Copy link

github-actions bot commented Dec 9, 2024

🐰 Bencher Report

Branch1147/merge
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
tests/nest_continuous_benchmarking/test_nest_continuous_benchmarking.py::TestNESTContinuousBenchmarking::test_stdp_nn_synapse📈 view plot
⚠️ NO THRESHOLD
3,978,885,874.20
🐰 View full continuous benchmarking report in Bencher

@pnbabu pnbabu requested a review from clinssen December 9, 2024 16:23
@pnbabu pnbabu added the bug label Dec 10, 2024
tests/nest_tests/test_integrate_odes.py Outdated Show resolved Hide resolved
@pnbabu pnbabu requested a review from clinssen December 11, 2024 14:12
@clinssen clinssen merged commit 0596e8e into nest:master Dec 16, 2024
10 of 11 checks passed
@clinssen
Copy link
Contributor

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants