-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve exit signal related log message #4240
Improve exit signal related log message #4240
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also change debug!("wait thread {} done", name);
to info
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. 💙
a3aab9a
to
317dc42
Compare
The unit test
|
What problem does this PR solve?
When ckb received exit signal multiple times, it will print:
This shouldn't be an
ERROR
level log, should downgrade the log level fromERROR
toINFO
.What's Changed:
Related changes
ERROR
toINFO
when ckb received exit signal multiple time.DEBUG
toINFO
Check List
Tests
Side effects
Release note