Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve exit signal related log message #4240

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Nov 20, 2023

What problem does this PR solve?

When ckb received exit signal multiple times, it will print:

error!("send exit signal to channel failed since the channel is full, this should not happen")

This shouldn't be an ERROR level log, should downgrade the log level from ERROR to INFO.

What's Changed:

Related changes

  • Downgrade log level from ERROR to INFO when ckb received exit signal multiple time.
  • Upgrade exit signal related log from DEBUG to INFO

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note

None: Exclude this PR from the release note.

@eval-exec eval-exec requested a review from a team as a code owner November 20, 2023 07:11
@eval-exec eval-exec requested review from doitian and removed request for a team November 20, 2023 07:11
@eval-exec eval-exec marked this pull request as draft November 20, 2023 07:12
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also change debug!("wait thread {} done", name); to info?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. 💙

@eval-exec eval-exec self-assigned this Nov 22, 2023
@eval-exec eval-exec added the t:doc Type: Documentation label Nov 22, 2023
@eval-exec eval-exec force-pushed the exec/improve-exit-signal-related-log-level branch from a3aab9a to 317dc42 Compare November 22, 2023 08:26
@eval-exec eval-exec marked this pull request as ready for review November 22, 2023 08:49
@eval-exec eval-exec marked this pull request as draft November 22, 2023 08:49
@eval-exec eval-exec marked this pull request as ready for review November 23, 2023 05:57
@quake quake added this pull request to the merge queue Nov 24, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 24, 2023
@eval-exec
Copy link
Collaborator Author

eval-exec commented Nov 24, 2023

The unit test test_should_have_no_output_in_cellbase_no_finalization_target failed,
caused by pthread lock: Invalid argument

     SIGABRT [   0.846s] ckb-verification-contextual tests::contextual_block_verifier::test_should_have_no_output_in_cellbase_no_finalization_target

--- STDOUT:              ckb-verification-contextual tests::contextual_block_verifier::test_should_have_no_output_in_cellbase_no_finalization_target ---

running 1 test
test tests::contextual_block_verifier::test_should_have_no_output_in_cellbase_no_finalization_target ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 17 filtered out; finished in 0.71s


--- STDERR:              ckb-verification-contextual tests::contextual_block_verifier::test_should_have_no_output_in_cellbase_no_finalization_target ---
pthread lock: Invalid argument

error: test run failed
make: *** [test] Error 100
Error: Process completed with exit code 2.

@zhangsoledad zhangsoledad added this pull request to the merge queue Nov 24, 2023
Merged via the queue into nervosnetwork:develop with commit 9995c8c Nov 24, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:doc Type: Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants