Skip to content

Commit

Permalink
Rename persistence file to avoid transient from other test
Browse files Browse the repository at this point in the history
This is a quick bandaid to make persistence tests less susceptible to
issues from every test using the same log file.
  • Loading branch information
fhunleth committed Jan 28, 2025
1 parent e26cf49 commit 4498e6d
Showing 1 changed file with 14 additions and 12 deletions.
26 changes: 14 additions & 12 deletions test/ring_logger/persistence_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,10 @@ defmodule RingLogger.PersistenceTest do

alias RingLogger.Persistence

@persistence_log_name "test/persistence_test.log"

test "saving logs" do
File.rm("test/persistence.log")
File.rm(@persistence_log_name)

logs = [
%{
Expand All @@ -23,15 +25,15 @@ defmodule RingLogger.PersistenceTest do
}
]

:ok = Persistence.save("test/persistence.log", logs)
:ok = Persistence.save(@persistence_log_name, logs)

assert File.exists?("test/persistence.log")
assert File.exists?(@persistence_log_name)

File.rm("test/persistence.log")
File.rm(@persistence_log_name)
end

test "loading logs" do
File.rm("test/persistence.log")
File.rm(@persistence_log_name)

logs = [
%{
Expand All @@ -50,24 +52,24 @@ defmodule RingLogger.PersistenceTest do
}
]

:ok = Persistence.save("test/persistence.log", logs)
:ok = Persistence.save(@persistence_log_name, logs)

loaded_logs = Persistence.load("test/persistence.log")
loaded_logs = Persistence.load(@persistence_log_name)

assert logs == loaded_logs

File.rm("test/persistence.log")
File.rm(@persistence_log_name)
end

test "file was corrupted" do
File.write!("test/persistence.log", "bad file")
File.write!(@persistence_log_name, "bad file")

assert {:error, :corrupted} = Persistence.load("test/persistence.log")
assert {:error, :corrupted} = Persistence.load(@persistence_log_name)

File.rm("test/persistence.log")
File.rm(@persistence_log_name)
end

test "file doesn't exist" do
assert {:error, :enoent} = Persistence.load("test/persistence.log")
assert {:error, :enoent} = Persistence.load(@persistence_log_name)
end
end

0 comments on commit 4498e6d

Please sign in to comment.