Skip to content

Commit

Permalink
Merge #298 "check count for 'not None' instead of truthy"
Browse files Browse the repository at this point in the history
  • Loading branch information
justinmk authored Feb 5, 2018
2 parents 060757c + 2689ddc commit 320cb7d
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 1 deletion.
2 changes: 1 addition & 1 deletion neovim/plugin/decorators.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def dec(f):

if range is not None:
opts['range'] = '' if range is True else str(range)
elif count:
elif count is not None:
opts['count'] = count

if bang:
Expand Down
30 changes: 30 additions & 0 deletions test/test_decorators.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
from nose.tools import with_setup, eq_ as eq, ok_ as ok

from neovim.plugin.decorators import command


def test_command_count():
def function():
"A dummy function to decorate."
return

# ensure absence with default value of None
decorated = command('test')(function)
ok('count' not in decorated._nvim_rpc_spec['opts'])

# ensure absence with explicit value of None
count_value = None
decorated = command('test', count=count_value)(function)
ok('count' not in decorated._nvim_rpc_spec['opts'])

# Test presesence with value of 0
count_value = 0
decorated = command('test', count=count_value)(function)
ok('count' in decorated._nvim_rpc_spec['opts'])
eq(decorated._nvim_rpc_spec['opts']['count'], count_value)

# Test presence with value of 1
count_value = 1
decorated = command('test', count=count_value)(function)
ok('count' in decorated._nvim_rpc_spec['opts'])
eq(decorated._nvim_rpc_spec['opts']['count'], count_value)

0 comments on commit 320cb7d

Please sign in to comment.