:terminal improvements #5431

justinmk · 2016-10-05T03:55:21Z

AprilArcus · 2016-11-02T00:05:04Z

I think it would be really cool if terminal could support cmdwin - c.f. brettanomyces/nvim-terminus#7

In particular, this would be great for writing multi-line functions in REPLs.

bew · 2016-12-02T14:53:44Z

would it be possible to handle :set nowrap in terminal buffer ?

justinmk · 2016-12-02T15:26:55Z

~~Yes, by telling libvterm a very long width. I have a pending PR that helps with this.~~

edit: That hack isn't going to work, because it will confuse interactive applications, not to mention tools like pytest which center text based on the TTY width.

bew · 2017-01-20T10:13:54Z

for the following improvment :

User-initiated :! invocations should silently use :terminal instead

Which terminal should be used ? We could send a RequestTerminal event, and see if a particular variable is set. If it is, use the terminal from the variable, or create a new terminal (new tab ? h/v split ?)

justinmk · 2017-01-20T10:16:35Z

The details of each item can be discussed as PRs are proposed for them. But at least initially the goal is only to match the traditional semantics of :!, so some sort of long-lived scratch buffer would be used.

Partial solution to neovim#2637. Will crash if *all* lines are deleted. References neovim#2607 References neovim#2637 References neovim#5431

Partial step towards neovim#2637. Will crash if *all* lines are deleted. Closes neovim#2607 References neovim#5431

bohrshaw · 2017-02-27T12:37:00Z

Well, I see (the last line of) a terminal buffer could serve as a really flexible readline-like interface, if only we can enter Insert Mode on a terminal buffer.

justinmk · 2017-02-27T13:04:04Z

@bohrshaw See this thread: #6142 (comment)

- 'bufhidden=hide' allows intuitive behavior even with global 'nohidden'. - 'modified' is a natural way to prevent loss of work. And the user can set 'nomodified' for cases where they don't want to be prompted. - With bufhidden={delete,wipe}: terminal buffer is restarted when the user returns to a deleted/wiped terminal buffer. Closes neovim#2368 Closes neovim#3340 References neovim#5431 Remove some special-case checks; instead leverage existing checks for 'bufhidden' (b_p_bh) and 'buftype' (b_p_bt). TODO: - With bufhidden=unload, the buffer is blank if the user returns to an unloaded terminal buffer. We should instead save the terminal scrollback to a file, then reload that.

tssm · 2020-03-11T09:16:07Z

I know that I may loose the argument here, but I think Neovim :terminal behaves the right way already, and I would whish :help and other "special" buffers (e.g. quick fix) behave like it. Here are the reasons:

Vim tabs are actually the right design, each tab is a layout and the user can switch between them easily. When :help (and :copen and probably others that I don't know about) is run the whole point of having different layouts on each tab is lost.
Most commands behave the same, with exceptions, so the user must remember those especial cases to avoid disrupting the layout. Even if something like :0te is implemented (I would prefer something like :current te if it happens), there would be a default behaviour and a bunch of special cases :( I prefer consistency.

One can argue that the user that the user could have custom commands with the desire behaviour, and that's what I do, but it would be awesome if Neovim where more consistent than Vim, so I wouldn't need to remember to use my custom commands instead of the default :help. I don't expect the behaviour of :help to be changed, I know compatibility with Vim is more important, but it would be nice if :terminal was kept as is (plus support for :vertical, :tab and others)

ddickstein · 2021-08-13T15:30:41Z

@justinmk can you elaborate on the plan for :read !foo? In the original post you write, ":! should use :terminal internally. Doesn't affect :read !foo etc." and then say ":read :term foo should work like :read !foo" What does this mean? It sounds like :read !foo isn't going to be changed by any of the :! plans, and that :read :term foo is going to be a new supported syntax that will have identical semantics to the current :read !foo. Is that correct?

vim-patch:8.0.1119: quitting a split terminal window kills the job N/A, or tracked in neovim#5431 vim-patch:8.0.1307: compiler warning for ignoring return value N/A vim-patch:8.0.1335: writefile() using fsync() may give an error N/A vim-patch:8.0.1339: no test for what 8.0.1335 fixes already merged in 5972ff0 vim-patch:8.0.1367: terminal test hangs, executing abcde N/A vim-patch:8.0.1562: the terminal debugger can't set breakpoint with mouse we have all :Termdebug changes vim-patch:8.0.1609: shell commands in the GUI use a dumb terminal tracked in neovim#5431 vim-patch:8.0.1616: Win32: shell commands in the GUI open a new console (guioptions="!") tracked in neovim#1496 vim-patch:8.0.1706: cannot sent CTRL-\ to a terminal window already possible via :call chansend()

vim-patch:8.0.1119: quitting a split terminal window kills the job N/A, or tracked in #5431 vim-patch:8.0.1307: compiler warning for ignoring return value N/A vim-patch:8.0.1335: writefile() using fsync() may give an error N/A vim-patch:8.0.1339: no test for what 8.0.1335 fixes already merged in 5972ff0 vim-patch:8.0.1367: terminal test hangs, executing abcde N/A vim-patch:8.0.1562: the terminal debugger can't set breakpoint with mouse we have all :Termdebug changes vim-patch:8.0.1609: shell commands in the GUI use a dumb terminal tracked in #5431 vim-patch:8.0.1616: Win32: shell commands in the GUI open a new console (guioptions="!") tracked in #1496 vim-patch:8.0.1706: cannot sent CTRL-\ to a terminal window already possible via :call chansend()

vim-patch:8.0.1119: quitting a split terminal window kills the job N/A, or tracked in neovim#5431 vim-patch:8.0.1307: compiler warning for ignoring return value N/A vim-patch:8.0.1335: writefile() using fsync() may give an error N/A vim-patch:8.0.1339: no test for what 8.0.1335 fixes already merged in 5972ff0 vim-patch:8.0.1367: terminal test hangs, executing abcde N/A vim-patch:8.0.1562: the terminal debugger can't set breakpoint with mouse we have all :Termdebug changes vim-patch:8.0.1609: shell commands in the GUI use a dumb terminal tracked in neovim#5431 vim-patch:8.0.1616: Win32: shell commands in the GUI open a new console (guioptions="!") tracked in neovim#1496 vim-patch:8.0.1706: cannot sent CTRL-\ to a terminal window already possible via :call chansend()

- 'bufhidden=hide' allows intuitive behavior even with global 'nohidden'. - 'modified' is a natural way to prevent loss of work. And the user can set 'nomodified' for cases where they don't want to be prompted. - With bufhidden={delete,wipe}: terminal buffer is restarted when the user returns to a deleted/wiped terminal buffer. Closes neovim#2368 Closes neovim#3340 References neovim#5431 Remove some special-case checks; instead leverage existing checks for 'bufhidden' (b_p_bh) and 'buftype' (b_p_bt). TODO: - With bufhidden=unload, the buffer is blank if the user returns to an unloaded terminal buffer. We should instead save the terminal scrollback to a file, then reload that.

There are 6 remaining 8.0.x patches, tracked in: neovim#5431

There are 6 remaining 8.0.x patches, tracked in: #5431

There are 6 remaining 8.0.x patches, tracked in: neovim#5431

This commit enables piping the current buffer's content to a job running in a terminal with `:%term job`. It does so in a way that makes the old `:%term sudo tee` trick work again. Closes neovim#22157 Maybe good enough to close neovim#12103 Relates to neovim#5431

tmillr · 2023-09-21T22:56:19Z

terminal windows in a session are not properly restored

It'd be cool if there were the option (e.g. maybe something in 'sessionoptions') to have scrollback restored (or an api to be able to do this manually, like get and set scrollback functions). By default, manpages don't get restored correctly either last I checked.

justinmk added the terminal built-in :terminal or :shell label Oct 5, 2016

justinmk added this to the 0.2 milestone Oct 5, 2016

justinmk self-assigned this Oct 5, 2016

jamessan mentioned this issue Oct 28, 2016

Command to open a terminal in a new tab #5541

Closed

This was referenced Nov 4, 2016

Exiting :terminal kills split #5176

Open

:!{cmd} is broken in neovim #5580

Closed

justinmk modified the milestones: 0.3, 0.2 Nov 27, 2016

justinmk mentioned this issue Jan 20, 2017

:!command does not handle bold characters #5980

Closed

justinmk mentioned this issue Feb 11, 2017

:terminal does not use command modifiers #6093

Closed

justinmk added a commit to justinmk/neovim that referenced this issue Feb 19, 2017

terminal: Allow undo and 'modifiable'.

c222fbe

Partial solution to neovim#2637. Will crash if *all* lines are deleted. References neovim#2607 References neovim#2637 References neovim#5431

justinmk mentioned this issue Feb 19, 2017

terminal: 'modifiable'; 'scrollback'; follow output only if cursor is on last line #6142

Merged

justinmk added a commit to justinmk/neovim that referenced this issue Feb 22, 2017

terminal: Allow undo and 'modifiable'.

a3a8b1e

Partial solution to neovim#2637. Will crash if *all* lines are deleted. References neovim#2607 References neovim#2637 References neovim#5431

justinmk added a commit to justinmk/neovim that referenced this issue Feb 24, 2017

terminal: Allow undo and 'modifiable'.

8a6433b

Partial solution to neovim#2637. Will crash if *all* lines are deleted. References neovim#2607 References neovim#2637 References neovim#5431

justinmk added a commit to justinmk/neovim that referenced this issue Feb 25, 2017

terminal: Allow undo and 'modifiable'.

659cdd6

Partial solution to neovim#2637. Will crash if *all* lines are deleted. References neovim#2607 References neovim#2637 References neovim#5431

justinmk added a commit to justinmk/neovim that referenced this issue Feb 25, 2017

terminal: Allow undo and 'modifiable'.

81f80a5

Partial step towards neovim#2637. Will crash if *all* lines are deleted. Closes neovim#2607 References neovim#5431

justinmk added a commit to justinmk/neovim that referenced this issue Feb 26, 2017

terminal: Allow undo and 'modifiable'.

fedb844

Partial step towards neovim#2637. Will crash if *all* lines are deleted. Closes neovim#2607 References neovim#5431

justinmk mentioned this issue Feb 28, 2017

terminal: Keep cursor position; Disable 'cursorline' #6185

Merged

This was referenced Mar 7, 2017

:terminal range - ":%term foo" should read the output of foo #6233

Open

Wrong/Weird colors with :! #6273

Closed

goerz mentioned this issue Apr 17, 2018

:! (bang) and system() are not interactive #1496

Open

justinmk mentioned this issue Jul 17, 2019

TUI: system(), systemlist(), :! in same process-group #8678

Open

This comment has been minimized.

Sign in to view

clason modified the milestones: 0.6, 0.7 Nov 30, 2021

justinmk mentioned this issue May 16, 2022

fix(version.c): mark N/A vim patches #18587

Merged

justinmk mentioned this issue Jul 4, 2022

vim-patch:8.0.1732 / fix(terminal): crash if TermClose deletes own buffer #19222

Merged

tssm mentioned this issue Jul 16, 2022

Open help tag on the current window by default nvim-telescope/telescope.nvim#2080

Open

justinmk added a commit to justinmk/neovim that referenced this issue Oct 21, 2022

vim-patch: bump VIM_VERSION from 8.0 => 8.1

a709c5e

There are 6 remaining 8.0.x patches, tracked in: neovim#5431

justinmk mentioned this issue Oct 21, 2022

vim-patch: bump VIM_VERSION from 8.0 => 8.1 #20762

Merged

justinmk added a commit that referenced this issue Oct 21, 2022

vim-patch: bump VIM_VERSION from 8.0 => 8.1 #20762

24c9561

There are 6 remaining 8.0.x patches, tracked in: #5431

justinmk mentioned this issue Nov 8, 2022

[WIP] Improvements to Terminal #2683

Closed

dundargoc pushed a commit to dundargoc/neovim that referenced this issue Jan 15, 2023

vim-patch: bump VIM_VERSION from 8.0 => 8.1 neovim#20762

c5d688c

There are 6 remaining 8.0.x patches, tracked in: neovim#5431

bfredl modified the milestones: 0.9, 0.10 Feb 2, 2023

glacambre mentioned this issue Feb 23, 2023

feat(terminal): allow piping to jobs #22374

Draft

justinmk mentioned this issue Feb 18, 2024

Terminal buffer's bufhidden behavior is inconsistent #27508

Open

dundargoc modified the milestones: 0.10, backlog Mar 12, 2024

tssm mentioned this issue May 22, 2024

feat(terminal)!: open :terminal in a split by default #24914

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

:terminal improvements #5431

:terminal improvements #5431

justinmk commented Oct 5, 2016 •

edited by zeertzjq

Loading

AprilArcus commented Nov 2, 2016 •

edited

Loading

bew commented Dec 2, 2016

justinmk commented Dec 2, 2016 •

edited

Loading

bew commented Jan 20, 2017

justinmk commented Jan 20, 2017

bohrshaw commented Feb 27, 2017 •

edited

Loading

justinmk commented Feb 27, 2017

tssm commented Mar 11, 2020

This comment has been minimized.

ddickstein commented Aug 13, 2021 •

edited

Loading

tmillr commented Sep 21, 2023 •

edited

Loading

:terminal improvements #5431

:terminal improvements #5431

Comments

justinmk commented Oct 5, 2016 • edited by zeertzjq Loading

AprilArcus commented Nov 2, 2016 • edited Loading

bew commented Dec 2, 2016

justinmk commented Dec 2, 2016 • edited Loading

bew commented Jan 20, 2017

justinmk commented Jan 20, 2017

bohrshaw commented Feb 27, 2017 • edited Loading

justinmk commented Feb 27, 2017

tssm commented Mar 11, 2020

This comment has been minimized.

ddickstein commented Aug 13, 2021 • edited Loading

tmillr commented Sep 21, 2023 • edited Loading

justinmk commented Oct 5, 2016 •

edited by zeertzjq

Loading

AprilArcus commented Nov 2, 2016 •

edited

Loading

justinmk commented Dec 2, 2016 •

edited

Loading

bohrshaw commented Feb 27, 2017 •

edited

Loading

ddickstein commented Aug 13, 2021 •

edited

Loading

tmillr commented Sep 21, 2023 •

edited

Loading