Skip to content

Commit

Permalink
revert to previous version as website reverted their changes too
Browse files Browse the repository at this point in the history
  • Loading branch information
neothematrix committed Mar 30, 2022
1 parent eea5340 commit a3ad336
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ my_password='add base64 encoded password here'
debug_lvl=2
echo -e "$(crontab -l)"$'\n'"12 3 * * 1,3,5 docker run --rm --network host moebiuss/noip-renew ${my_username} ${my_password} ${debug_lvl}" | crontab -
```
NOTE: with newer versions of ChromeDriver (>v99) you might need to increase the shm size of the container otherwise ChromeDriver will crash and throw an exception. To do it, you can just add the "--shm-size="512m" flag to the docker run command.

## Remarks

Expand Down
6 changes: 3 additions & 3 deletions noip-renew.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class Robot:

USER_AGENT = "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:64.0) Gecko/20100101 Firefox/64.0"
LOGIN_URL = "https://www.noip.com/login"
HOST_URL = "https://www.noip.com/redirect/mynoip?force=true&intended=dynamic-dns"
HOST_URL = "https://my.noip.com/dynamic-dns"

def __init__(self, username, password, debug):
self.debug = debug
Expand Down Expand Up @@ -90,9 +90,9 @@ def login(self):
ele_pwd.send_keys(Keys.ENTER)

# After Loggin browser loads my.noip.com page - give him some time to load
# 'free-callout' element is near the end of html, so html have been loaded
# 'noip-cart' element is near the end of html, so html have been loaded
try:
elem = WebDriverWait(self.browser, 10).until( EC.presence_of_element_located((By.ID, "free-callout")))
elem = WebDriverWait(self.browser, 10).until( EC.presence_of_element_located((By.ID, "noip-cart")))
except:
raise Exception("my.noip.com page could not load")

Expand Down

0 comments on commit a3ad336

Please sign in to comment.