Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: use tigther storcon scopes #9696

Merged
merged 1 commit into from
Nov 8, 2024
Merged

tests: use tigther storcon scopes #9696

merged 1 commit into from
Nov 8, 2024

Conversation

VladLazar
Copy link
Contributor

Problem

#9596 did not update tests because that would've broken the compat tests.

Summary of Changes

Use infra scope where possible.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Problem

#9596 did not update tests
because that would've broken the compat tests.

Summary of Changes

Use infra scope where possible.
@VladLazar VladLazar requested a review from jcsp November 8, 2024 15:49
@VladLazar VladLazar enabled auto-merge (squash) November 8, 2024 16:15
Copy link

github-actions bot commented Nov 8, 2024

5346 tests run: 5124 passed, 0 failed, 222 skipped (full report)


Flaky tests (2)

Postgres 17

Code coverage* (full report)

  • functions: 31.7% (7870 of 24804 functions)
  • lines: 49.4% (62257 of 125992 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
6910bd7 at 2024-11-08T16:55:25.170Z :recycle:

@VladLazar VladLazar merged commit 30680d1 into main Nov 8, 2024
82 checks passed
@VladLazar VladLazar deleted the vlad/use-tigh-scopes branch November 8, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants