Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: Unify local and remote conn pool client structures #9604

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

awarus
Copy link
Contributor

@awarus awarus commented Nov 1, 2024

Unify client, EndpointConnPool and DbUserConnPool for remote and local conn.

  • Use new ClientDataEnum for additional client data.
  • Add ClientInnerCommon client structure.
  • Remove Client and EndpointConnPool code from local_conn_pool.rs

Problem

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@awarus awarus requested a review from a team as a code owner November 1, 2024 10:34
@awarus awarus requested a review from conradludgate November 1, 2024 10:34
@awarus awarus force-pushed the conn_pool_refactor2 branch from b70dba1 to 322b217 Compare November 1, 2024 10:36
Copy link

github-actions bot commented Nov 1, 2024

5328 tests run: 5106 passed, 0 failed, 222 skipped (full report)


Code coverage* (full report)

  • functions: 31.6% (7791 of 24691 functions)
  • lines: 49.0% (61134 of 124737 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
8535107 at 2024-11-05T15:17:23.695Z :recycle:

@awarus awarus force-pushed the conn_pool_refactor2 branch 2 times, most recently from f969d22 to 465a58b Compare November 1, 2024 12:10
Copy link
Contributor

@conradludgate conradludgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@awarus awarus force-pushed the conn_pool_refactor2 branch 2 times, most recently from c944196 to ab157d5 Compare November 5, 2024 10:16
@awarus awarus requested a review from conradludgate November 5, 2024 10:19
@awarus awarus force-pushed the conn_pool_refactor2 branch 2 times, most recently from 7fd2a0e to d992260 Compare November 5, 2024 12:20
Copy link
Contributor

@conradludgate conradludgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks

Unify client, EndpointConnPool and DbUserConnPool for remote and local conn.
- Use new ClientDataEnum for additional client data.
- Add ClientInnerCommon client structure.
- Remove Client and EndpointConnPool code from local_conn_pool.rs
@awarus awarus force-pushed the conn_pool_refactor2 branch from d992260 to 8535107 Compare November 5, 2024 14:08
@awarus awarus merged commit 2f1a56c into main Nov 5, 2024
80 checks passed
@awarus awarus deleted the conn_pool_refactor2 branch November 5, 2024 15:33
@awarus awarus mentioned this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants