Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI(build-and-test-locally): set session-timeout for pytest #10831

Merged
merged 2 commits into from
Feb 15, 2025

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Feb 14, 2025

Problem

Sometimes, a regression test run gets stuck (taking more than 60 minutes) and is killed by GitHub's timeout-minutes without leaving any traces in the test results database.
I find no correlation between this and either the build type, the architecture, or the Postgres version.

See: https://neonprod.grafana.net/goto/nM7ih7cHR?orgId=1

Summary of changes

  • Bump pytest-timeout to the version that supports --session-timeout
  • Set --session-timeout to (timeout-minutes - 10 minutes) * 60 seconds in Attempt to stop tests gracefully to generate test reports until they are forcibly stopped by the stricter timeout-minutes limit.

@bayandin bayandin requested a review from a team as a code owner February 14, 2025 16:48
Copy link

7524 tests run: 7136 passed, 0 failed, 388 skipped (full report)


Code coverage* (full report)

  • functions: 33.0% (8601 of 26050 functions)
  • lines: 48.9% (72556 of 148240 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
aee2fad at 2025-02-14T18:24:53.455Z :recycle:

Copy link
Contributor

@a-masterov a-masterov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bayandin bayandin added this pull request to the merge queue Feb 15, 2025
Merged via the queue into main with commit 2ec8dff Feb 15, 2025
98 checks passed
@bayandin bayandin deleted the bayandin/add-session-timeout branch February 15, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants