Skip to content

Commit

Permalink
Don't consider archived timelines for synthetic size calculation (#9497)
Browse files Browse the repository at this point in the history
Archived timelines should not count towards synthetic size.

Closes #9384.

Part of #8088.
  • Loading branch information
arpad-m authored Oct 26, 2024
1 parent 80262e7 commit e727788
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions pageserver/src/tenant/size.rs
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,8 @@ pub(super) async fn gather_inputs(
// but it is unlikely to cause any issues. In the worst case,
// the calculation will error out.
timelines.retain(|t| t.is_active());
// Also filter out archived timelines.
timelines.retain(|t| t.is_archived() != Some(true));

// Build a map of branch points.
let mut branchpoints: HashMap<TimelineId, HashSet<Lsn>> = HashMap::new();
Expand Down

1 comment on commit e727788

@github-actions
Copy link

@github-actions github-actions bot commented on e727788 Oct 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5370 tests run: 5145 passed, 0 failed, 225 skipped (full report)


Flaky tests (2)

Postgres 17

Code coverage* (full report)

  • functions: 31.3% (7689 of 24546 functions)
  • lines: 48.8% (60463 of 123953 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
e727788 at 2024-10-27T00:55:48.008Z :recycle:

Please sign in to comment.