Skip to content

Commit

Permalink
Increase the extension server request timeout to 1 minute (#10800)
Browse files Browse the repository at this point in the history
pg_search is 46ish MB. All other remote extensions are around hundeds of
KB. 3 seconds is not long enough to download the tarball if the S3
gateway cache doesn't already contain a copy. According to our setup,
the cache is limited to 10 GB in size and anything that has not been
accessed for an hour is purged.

This is really bad for scaling to 0, even more so if you're the only
project actively using the extension in a production Kubernetes cluster.

Signed-off-by: Tristan Partin <tristan@neon.tech>
  • Loading branch information
tristan957 authored Feb 13, 2025
1 parent a4d0a34 commit b6f972e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pgxn/neon/extension_server.c
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

#include "utils/guc.h"

#include "extension_server.h"
#include "extension_server.h"
#include "neon_utils.h"

static int extension_server_port = 0;
Expand Down Expand Up @@ -45,7 +45,7 @@ neon_download_extension_file_http(const char *filename, bool is_library)
handle = alloc_curl_handle();

curl_easy_setopt(handle, CURLOPT_CUSTOMREQUEST, "POST");
curl_easy_setopt(handle, CURLOPT_TIMEOUT, 3L /* seconds */ );
curl_easy_setopt(handle, CURLOPT_TIMEOUT, 60L /* seconds */ );
}

compute_ctl_url = psprintf("http://localhost:%d/extension_server/%s%s",
Expand Down

1 comment on commit b6f972e

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7631 tests run: 7234 passed, 0 failed, 397 skipped (full report)


Flaky tests (1)

Postgres 17

Code coverage* (full report)

  • functions: 33.1% (8597 of 25948 functions)
  • lines: 49.0% (72546 of 147996 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
b6f972e at 2025-02-13T20:00:55.870Z :recycle:

Please sign in to comment.