Skip to content

Commit

Permalink
chore(proxy): remove allow_self_signed from regular proxy (#10157)
Browse files Browse the repository at this point in the history
I noticed that the only place we use this flag is for testing console
redirect proxy. Makes sense to me to make this assumption more explicit.
  • Loading branch information
conradludgate authored Dec 16, 2024
1 parent 3d30a7a commit 2e4c9c5
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions proxy/src/proxy/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -191,13 +191,6 @@ impl ClientMode {
}
}

pub(crate) fn allow_self_signed_compute(&self, config: &ProxyConfig) -> bool {
match self {
ClientMode::Tcp => config.allow_self_signed_compute,
ClientMode::Websockets { .. } => false,
}
}

fn hostname<'a, S>(&'a self, s: &'a Stream<S>) -> Option<&'a str> {
match self {
ClientMode::Tcp => s.sni_hostname(),
Expand Down Expand Up @@ -355,7 +348,8 @@ pub(crate) async fn handle_client<S: AsyncRead + AsyncWrite + Unpin>(
params_compat,
params: &params,
locks: &config.connect_compute_locks,
allow_self_signed_compute: mode.allow_self_signed_compute(config),
// only used for console redirect testing.
allow_self_signed_compute: false,
},
&user_info,
config.wake_compute_retry_config,
Expand Down

1 comment on commit 2e4c9c5

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7095 tests run: 6797 passed, 1 failed, 297 skipped (full report)


Failures on Postgres 17

# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_timeline_archival_chaos[release-pg17]"
Flaky tests (7)

Postgres 17

  • test_compute_pageserver_connection_stress: debug-x86-64
  • test_physical_replication_config_mismatch_too_many_known_xids: release-arm64
  • test_sharding_split_failures[failure0]: debug-x86-64

Postgres 16

  • test_pgdata_import_smoke[None-1024-RelBlockSize.MULTIPLE_RELATION_SEGMENTS]: release-arm64

Postgres 15

  • test_pgdata_import_smoke[8-1024-RelBlockSize.MULTIPLE_RELATION_SEGMENTS]: release-arm64
  • test_pgdata_import_smoke[None-1024-RelBlockSize.MULTIPLE_RELATION_SEGMENTS]: release-arm64
  • test_physical_replication_config_mismatch_max_locks_per_transaction: release-arm64

Test coverage report is not available

The comment gets automatically updated with the latest test results
2e4c9c5 at 2024-12-16T17:13:05.576Z :recycle:

Please sign in to comment.