feat(neon): `JsFunction::bind()` and `Object::prop()`#1056

Merged

dherman merged 37 commits intomainfrom prop-options

Oct 1, 2024

+891-278

Commits on Sep 27, 2024

Implement JsFunction::bind(), which creates a builder for calling a function using the Try{From,Into}Js traits.
dherman
committed
prettier
dherman
committed
cargo fmt --all
dherman
committed
Add PropOptions and Object::prop() for accessing object properties expressively
dherman
committed
api doc formatting
dherman
committed
tweak test name for clarity
dherman
committed
Optimization: only do the function type check of the callee when calling BindOptions::apply()
dherman
committed
rebase: {Bind,Prop}Options take Cx instead of generic C: Context
dherman
committed
remove unnecessary sys::fun::call helper, and add test case for calling non-functions with .bind()
dherman
committed
prettier
dherman
committed
cargo fmt --all
dherman
committed
style: move long type parameter list to where-clause
dherman
committed
more style nits (where-clauses)
dherman
committed
arg_with's closure doesn't need to require a Result, since TryIntoJs is already implemented for NeonResult
dherman
committed
remove unnecessary unsafe: use .as_value() instead
dherman
committed
BindOptions::this() takes a TryIntoJs (and is therefore fallible)
dherman
committed
store object in PropOptions as a JsObject so it doesn't need a type parameter other than for the key
dherman
committed
avoid the double-type-check of eagerly downcasting to function when calling .bind(), since it's performed when calling .apply()
dherman
committed
style: move the InvalidArg tag check to a match guard

dherman
and
kjvalencik
committed
argc can be usize now that we're not using the c++ backend
dherman
committed
BindOptions::args_with() and equivalent BindOptions::args(With(...))
dherman
committed
more readable logic for impl_arguments! and impl_into_arguments! macros
dherman
committed
move call_local into a method of ValueInternal, so there's less of a weird inconsistency between the callee being something other than a Handle vs the other args
dherman
committed
co-locate the impl of TryIntoArguments for With into the same module as the other impls
dherman
committed
safety comment for .prop()
dherman
committed
PropOptions.set() returns self
dherman
committed
- put back the O: Object type parameter to PropOptions for more precise typing
dherman
committed
add PropOptions::set_with
dherman
committed
eliminate uses of .get() and .set() in API docs
dherman
committed

Commits on Sep 30, 2024

KJ's suggested doc improvements
dherman
committed