Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed query argument from GraphRAG's .search method #145

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

willtai
Copy link
Contributor

@willtai willtai commented Sep 19, 2024

Description

Removed query argument from GraphRAG's .search method. There was previously a warning to deprecate this. Users will not be able to use query and are now required to use query_text.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Documentation update
  • Project configuration change

Complexity

Complexity: Low

How Has This Been Tested?

  • Unit tests
  • E2E tests
  • Manual tests

Checklist

The following requirements should have been met (depending on the changes in the branch):

  • Documentation has been updated
  • Unit tests have been updated
  • E2E tests have been updated
  • Examples have been updated
  • New files have copyright header
  • CLA (https://neo4j.com/developer/cla/) has been signed
  • CHANGELOG.md updated if appropriate

@willtai
Copy link
Contributor Author

willtai commented Sep 19, 2024

@CodiumAI-Agent /update_changelog

@CodiumAI-Agent
Copy link

Changelog updates: 🔄

2024-09-19

Changed

  • Removed query argument from GraphRAG's .search method; users must now use query_text.

to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'

@willtai willtai marked this pull request as ready for review September 19, 2024 13:35
@willtai willtai force-pushed the remove-graphrag-query-argument-in-search branch from 572a187 to a076f4e Compare September 19, 2024 14:21
@willtai willtai force-pushed the remove-graphrag-query-argument-in-search branch from 9255321 to 6f87ec3 Compare September 30, 2024 10:42
@willtai willtai merged commit 7cb652d into neo4j:main Sep 30, 2024
8 checks passed
@CodiumAI-Agent
Copy link

Changelog updates: 🔄

2024-09-30

Changed

  • Removed query argument from the GraphRAG class' .search method; users must now use query_text.

to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'

@willtai willtai deleted the remove-graphrag-query-argument-in-search branch October 1, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants