Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nock as a dependency #6063

Closed
wants to merge 1 commit into from
Closed

Remove nock as a dependency #6063

wants to merge 1 commit into from

Conversation

angrykoala
Copy link
Member

Description

nock is no longer used in LTS and should be safe to remove

@angrykoala angrykoala requested a review from mjfwebb March 10, 2025 10:17
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2025

⚠️ No Changeset found

Latest commit: bb7dd18

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@angrykoala
Copy link
Member Author

Scratch this change, nock is used as a peer dependency of mock-jwks for jwks tests

@angrykoala angrykoala closed this Mar 10, 2025
@angrykoala angrykoala deleted the remove-nock branch March 10, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjfwebb mjfwebb mjfwebb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@angrykoala @mjfwebb