Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:#2697 fix aggregation filter for durations #4573

Conversation

Andy2003
Copy link
Contributor

Description

This PR fixes the usage of duration in aggregation filters.

Complexity

Complexity: Low

Issue

Closes #2697

Checklist

The following requirements should have been met (depending on the changes in the branch):

  • Documentation has been updated
  • TCK tests have been updated
  • Integration tests have been updated
  • Example applications have been updated
  • New files have copyright header
  • CLA (https://neo4j.com/developer/cla/) has been signed

Copy link

changeset-bot bot commented Jan 24, 2024

🦋 Changeset detected

Latest commit: 7e129da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@neo4j/graphql Patch
@neo4j/graphql-toolbox Patch
@neo4j/graphql-ogm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@neo4j-team-graphql
Copy link
Collaborator

neo4j-team-graphql commented Jan 24, 2024

Thanks for the Neo4j GraphQL Toolbox updates.

The Neo4j GraphQL Toolbox has now been torn down - reopening this PR will republish it.

@Andy2003 Andy2003 force-pushed the bugfix/gh-2697-fix-wrong-aggregation-filter-for-durations branch from 46f79dc to 7e129da Compare January 24, 2024 11:45
@neo4j-team-graphql
Copy link
Collaborator

neo4j-team-graphql commented Jan 24, 2024

Performance Report

No Performance Changes

Show Full Table
name dbHits old dbHits time (ms) old time (ms) maxRows
aggregations.TopLevelAggregate 3404 3404 34 44 1134
aggregations.TopLevelAggregateWithMultipleFields 6802 6802 42 55 1134
aggregations.NestedAggregation 16544 16544 61 67 2174
aggregations.AggregationWithWhere 11970 11970 44 63 2174
aggregations.AggregationWhereWithinNestedRelationships 22116478 22116478 2179 2239 2008534
aggregations.AggregationWhereWithinNestedConnections 22116478 22116478 2179 2119 2008534
aggregations.NestedCountFromMovieToActors 9701 9701 42 39 2174
aggregations.NestedCountFromActorsToMovie 9928 9928 34 38 2174
aggregations.DeeplyNestedCount 11062184 11062184 2783 2839 2008534
aggregations.InterfacesAggregations 6242 6242 42 52 2080
aggregations.InterfacesAggregationsWithTwoFields 11444 11444 68 91 2080
batch-create.BatchCreate 4200 4200 129 144 600
batch-create.BatchCreateSmall 77 77 104 75 11
connect.createAndConnect 14424 14424 192 182 3003
connections.Connection 14049 14049 72 60 2174
connections.NestedConnection 41068 41068 120 125 4516
create.SimpleMutation 7 7 48 54 1
cypher-directive.TopLevelMutationDirective 1135 1135 23 25 1134
delete.SimpleDelete 19401 19401 230 236 1040
delete.NestedDeleteInUpdate 19165 19165 179 189 1183
2871.NestedRelationshipFilter 23081 23099 53 61 4436
2925.SingleRelationshipFilter 6468 6468 36 45 1040
2925.NestedSingleRelationshipFilter 22891 22891 80 103 2174
2925.SingleRelationshipRequiredFilter 5201 5201 35 50 1040
2925.NestedSingleRelationshipRequiredFilter 9361 9361 49 64 1040
query.SimpleQuery 3121 3121 18 20 1040
query.SimpleQueryWithRelationship 16129 16129 41 52 2174
query.QueryWhere 9683 9679 30 38 2164
query.SimpleQueryWithNestedWhere 9850 9846 47 54 2164
query.Nested 10095502 10095502 6644 6906 2008534
query.NestedWithFilter 10074351 10074351 6560 6748 2004000
query.OrFilterOnRelationships 42178 41884 143 178 1672
query.OrFilterOnRelationshipsAndNested 35874 36002 179 226 1672
query.QueryWithNestedIn 13639 13277 46 55 1308
query.NestedConnectionWhere 9801 9801 50 64 2174
query.DeeplyNestedConnectionWhere 9860 9798 74 81 2174
query.DeeplyNestedWithRelationshipFilters 18800 18644 117 151 1598
query.NestedWithRelationshipSingleFilters 3865 3865 160 173 1134
query.Fulltext 64 64 34 31 16
query.FulltextWithNestedQuery 558 558 42 45 84
sorting-and-cypher.TopLevelSortWithCypher 14059 14059 46 50 2174
sorting-and-cypher.TopLevelConnectionSortWithCypher 14059 14059 67 68 2174
sorting-and-cypher.TopLevelSortWithCypherWithNested 14155 14143 62 62 2174
sorting-and-cypher.TopLevelConnectionSortWithCypherWithNested 14155 14143 109 131 2174
sorting-and-cypher.TopLevelSortWithExpensiveCypher 14592 14370 112 122 2174
sorting-and-cypher.TopLevelConnectionSortWithExpensiveCypher 14437 14299 102 121 2174
sorting.SortMultipleTypes 3498 3498 79 103 1040
sorting.SortMultipleTypesWithCypherWithCypher 14532 14494 100 122 2174
sorting.SortOnNestedFields 14049 14049 42 64 2174
sorting.SortDeeplyNestedFields 43148 43148 82 124 4516
sorting.ConnectionWithSort 3281 3281 66 99 1040
unions.SimpleUnionQuery 321 321 52 67 35
unions.SimpleUnionQueryWithMissingFields 293 293 53 55 35
unions.NestedUnion 410637 410637 286 278 33033
unions.NestedUnionWithMissingFields 384611 384611 252 272 33033
update.NestedUpdate 16143 16143 106 105 2002

Old Schema Generation: 23.635s
Schema Generation: 23.643s
Old Subgraph Schema Generation: 27.216s
Subgraph Schema Generation: 26.880s

Copy link
Contributor

@darrellwarde darrellwarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Andy2003!

@darrellwarde darrellwarde merged commit 90d2fd3 into neo4j:dev Jan 26, 2024
81 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2024
@Andy2003 Andy2003 deleted the bugfix/gh-2697-fix-wrong-aggregation-filter-for-durations branch January 26, 2024 18:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Status: Pull requests
Development

Successfully merging this pull request may close these issues.

Aggregation: wrong cypher to compare durations
3 participants