Adding Community detection example jupyter notebook (continued) #375
Conversation
✅ Deploy Preview for neo4j-graph-data-science-client ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@kedarghule the mentioned PR. Also asking @nvitucci to get some feedback on the wording :) |
Yeah I don't know why it was failing. I was planning to make more such PRs in the future as I keep learning :) Anyways, I see one check is still failing :/ Thanks @FlorentinD for making changes! Do let me know if any more work is needed on this from my end :) |
|
Great idea to add more notebooks as you keep learning! It was just a typo in the code which I fixed now. Also, added you as a collaborator to my fork. As some context, CI did not run on your PR as only internal contributor can kick off CI. This is helpful to avoid malicious people to run f.i. mining code on a PR. I will bring it up in our team to see what we can improve in the process. IMO its fine that only we care about the CI output and let you know, but it should be possible to kick off CI from your original PR |
Hi thanks for adding me to your fork :) I'll use it for future notebooks I intend to make :D |
There was a problem hiding this comment.
Thank you very much @kedarghule! I've just added a few small suggestions on the style.
|
@nvitucci Thanks for the suggestions. (@kedarghule I took the liberty to apply the comments directly :) ) |
Thank you for the suggestions @nvitucci and thanks for applying them before I woke up haha @FlorentinD :D |
* apply styling * add cleanup section and further ideas * cleanup the queries a bit * smaller rewording
Co-authored-by: Nicola Vitucci <nicola.vitucci@neo4j.com>
FlorentinD
force-pushed
the
community-notebook-kedar
branch
from
53f9259 to
3b1208e
Compare
|
I rebased on main, the latest failure was not related to us :) |
Thank you :D |
|
Congratulations on getting your first PR merged @kedarghule 🥳 |
based on #373.
Hopefully CI runs here now