-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example on how to CREATE db from the seed URI #2152
Conversation
modules/ROOT/pages/database-administration/standard-databases/create-databases.adoc
Outdated
Show resolved
Hide resolved
…create-databases.adoc
modules/ROOT/pages/database-administration/standard-databases/create-databases.adoc
Outdated
Show resolved
Hide resolved
…create-databases.adoc
modules/ROOT/pages/database-administration/standard-databases/create-databases.adoc
Outdated
Show resolved
Hide resolved
…create-databases.adoc
modules/ROOT/pages/database-administration/standard-databases/create-databases.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you that we can have some information here as well. I added some comments.
modules/ROOT/pages/database-administration/standard-databases/create-databases.adoc
Outdated
Show resolved
Hide resolved
| `s3:` + | ||
`gs:` + | ||
`azb:` | ||
| `s3://mybucket/backups/backup1.backup` + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, there is a mismatch between the examples and this table here and on the other page. In the examples, the URLs are s3:/mybucket/backups/backup1.backup, gs:/mybucket/backups/backup1.backup, and azb:/mystorageaccount.blob/backupscontainer/backup1.backup, while in the tables we see double // after the s3, gs, and azb. I am not sure which one is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, interesting indeed. If you look at the examples here, you'll see we use double slashes after s3:
, gs:
, and azb:
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I don't know now. Maybe you can ask someone.
modules/ROOT/pages/database-administration/standard-databases/create-databases.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/database-administration/standard-databases/create-databases.adoc
Outdated
Show resolved
Hide resolved
…create-databases.adoc Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
modules/ROOT/pages/database-administration/standard-databases/create-databases.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/database-administration/standard-databases/create-databases.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/database-administration/standard-databases/create-databases.adoc
Outdated
Show resolved
Hide resolved
…create-databases.adoc Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
…create-databases.adoc Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some more suggestions
modules/ROOT/pages/database-administration/standard-databases/create-databases.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/database-administration/standard-databases/create-databases.adoc
Outdated
Show resolved
Hide resolved
| `s3:` | ||
| `s3://mybucket/backups/backup1.backup` | ||
|
||
| `CloudSeedProvider` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| `CloudSeedProvider` | |
| `CloudSeedProvider` label:default[Default] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about using the Default label here. This is confusing. I think it will cause more questions than provide clarification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the default value of the config starting from 2025.01 only. I don't think we need such details here.
Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
We will move the content about seeding options to a separate page |
In some sense, we repeat information provided on the page Managing databases in a cluster . However, I don't see much harm in this repeating as information about seed options is relevant and can be very useful on the page where we speak on how to CREATE db in Neo4j.