Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes QPP with no comma bug in formatter #403

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

tomasnyberg
Copy link
Contributor

Description

In #402 Oskar pointed out that one of his queries refused to format, and it turned out the formatter was experiencing an internal bug. The culprit turned out to be a QPP that failed because we always assume there is a comma within it, even though it can look like this as well: {4}

This PR addresses that grammar case in visitQuantifier and adds a test for it.

Testing

Copy link

changeset-bot bot commented Mar 11, 2025

⚠️ No Changeset found

Latest commit: a89f2ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tomasnyberg tomasnyberg merged commit a50bfb3 into neo4j:main Mar 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants