Fixes QPP with no comma bug in formatter #403
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #402 Oskar pointed out that one of his queries refused to format, and it turned out the formatter was experiencing an internal bug. The culprit turned out to be a QPP that failed because we always assume there is a comma within it, even though it can look like this as well:
{4}
This PR addresses that grammar case in
visitQuantifier
and adds a test for it.Testing