Fixes IS CONNECTED concatenation bug in formatter #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tomasnyberg
changed the title
ncordon
approved these changes
Mar 11, 2025
simonthuresson
pushed a commit
to simonthuresson/cypher-language-support
that referenced
this pull request
Mar 12, 2025
simonthuresson
added a commit
that referenced
this pull request
Mar 12, 2025
* can change document * refactores format document * uses non deprecated type * changed import order back to original * updates readme for vs-code extension * Updates changelog * bumps vs-code extension version * Removes reordering of ON CREATE/MATCH clauses in formatter (#399) * Fixes IS CONNECTED concatenate bug in formatter (#401) * adds e2e tests for extension * modified test * deletes unused file --------- Co-authored-by: Tomas Nyberg <71550631+tomasnyberg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While testing something else, I noticed that 2 of the 1.1M sample queries were not passing the AST integrity check, due to
IS CONNECTEDwithin relations being concatenated intoISCONNECTED. The issue was related to us always concatenating for path lengths even though a path length is not always present. This PR resolves that issue.Testing