Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connections tree improvements #394

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Conversation

anderson4j
Copy link
Collaborator

Updates the connection tree with icons like this:
image
Also adds expanding on left click of a connection, and automatic expansion of the connection node on connection as seen here:

Screen.Recording.2025-03-07.113857.mp4

Copy link

changeset-bot bot commented Mar 7, 2025

⚠️ No Changeset found

Latest commit: f4ea505

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trello card/instruction from Greg mentions turning it blue on being active, but from the design folks I heard we couldnt mess with "official logo" stuff too much, so this was the best he found

Comment on lines +169 to +175
path.join(
__dirname,
'..',
'resources',
'images',
'Neo4jActiveLight.svg',
),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried if the icons are visible in Windows?

You can generate a .vsix package doing:

cd packages/vscode-extension
npx vsce package

and then installing that VSIX manually when you click on the Marketplace icon in VSCode:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks like they're still there if I do it this way. How is building/installing with a VSIX file (from the current repo) different from what I get by running the vscode playground in the current repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants