Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .cypher icon, file template and type #189

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

jamthief
Copy link
Contributor

Supports:

  • Creating a new Cypher file via the New > Cypher File menu
  • File type association as a Cypher File to prevent IntelliJ not "recognising" it
  • Custom file icon in open files tab

Copy link
Collaborator

@ncordon ncordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it'd be better if we had neo4j's official logo as file icon? Do we need the Cypher File.cypher.ft file in this pr?

@ncordon ncordon self-assigned this Mar 27, 2024
@jamthief
Copy link
Contributor Author

jamthief commented Mar 28, 2024

Maybe it'd be better if we had neo4j's official logo as file icon?

So I got this logo from the brand pack, it is designated for "Cypher", hence why I chose it! If you think it's better as the neo4j logo then I can change it, but I figured if we ever release this officially we'd probably get design to review it first.

Do we need the Cypher File.cypher.ft file in this pr?

Yeah, this provides a template for whatever content you want to appear when selecting "New > Cypher File" from the file menu.

@jamthief
Copy link
Contributor Author

jamthief commented Mar 28, 2024

Or if not the Cypher logo, we could use the brand shapes (node shapes on a hexagon grid): https://www.neo4j.design/40a8cff71/p/995201-brand-shapes

e.g. Cypher File - Icon

@ncordon ncordon merged commit e7a6d38 into neo4j:main Apr 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants