Prepare for extension publishing #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarDamkjaer
changed the title
OskarDamkjaer
changed the title
OskarDamkjaer
commented
Feb 29, 2024
| "bundle": "esbuild ./src/server.ts --bundle --format=cjs --platform=node --outfile=dist/cypher-language-server.js --minify", | ||
| "bundle-worker": "esbuild ./src/lintWorker.ts --bundle --format=cjs --platform=node --outfile=dist/lintWorker.js --minify", |
There was a problem hiding this comment.
without these changes, the worker doesn't properly bundle it's imports
ncordon
reviewed
Feb 29, 2024
|
|
||
| The following settings are available in VSCode once the plugin is installed, which can be set either through the `Settings` menu on VSCode or by creating a `.vscode/settings.json` file in the window opened by the play button. | ||
| - Easier database connection management |
There was a problem hiding this comment.
Add this maybe?
- Query execution
ncordon
reviewed
Feb 29, 2024
packages/vscode-extension/README.md
Outdated
Comment on lines
31
to
34
| - `cypherLSP.neo4j.connect`: If true it will attempt to connect to a Neo4j database to retrieve data used for completions. Defaults to `true` | ||
| - `cypherLSP.neo4j.user`: Defaults to `"neo4j"`, the default user for a local Neo4j instance | ||
| - `cypherLSP.neo4j.password`: Replace this with the password for the user above | ||
| - `cypherLSP.neo4j.URL`: Defaults to `"neo4j://localhost:7687"`, the default URL for a local Neo4j instance |
There was a problem hiding this comment.
We need to remove the cypherLSP from here.
Maybe it would be nicer to make url lower case everywhere?
There was a problem hiding this comment.
Yes I agree it'd be nicer
There was a problem hiding this comment.
I also changed it to be boltUrl instead, this way we don't have to rename it if we start supporting the HTTP api as well in the future
ncordon
reviewed
Feb 29, 2024
packages/vscode-extension/README.md
Outdated
|
|
||
| ### Debug | ||
|
|
||
| - `cypherLSP.trace.server`: Traces the communication between VS Code and the language server for debugging purposes. | ||
| - `cypherLSP.trace.server`: Traces the communication between VS Code and the language server for debugging purposes |
There was a problem hiding this comment.
Same, the cypherLSP is not there anymore, they are neo4j settings
ncordon
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the crash when dbschema isn't passed to the signature help and prepares our package for publishing.
Updates to our package.json based on the guidelines in the docs here:
https://code.visualstudio.com/api/references/extension-manifest
I've updated some "VSCode" to "VS Code", since that's how it's usually written in docs from microsoft.
Minimized the extension bundle, now it only includes the relevant files:
The gif needs to be referenced via https to render in the marketplace, as noted here and here. Let me know if you prefer one of the older gifs, a static image or something completely different 😄
I've also updated some wordings & descriptions, let me know what you think.