Updates grammar #179
Merged
Updates grammar #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we don't see any issues with having the preparser be separate I think it makes sense to have it be separate like you've done here, since that's how it's in the main database (?) |
OskarDamkjaer
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the 5.18 grammar from the database. Also it splits the
EXPLAINandPROFILEto a separate grammar. I'm happy to either have that pyramid of grammars or write it insideCypherCmdParserinstead. We will most probably need a more developed preparser sooner or later because all of thoseCYPHERoptions you can prefix a query with.