Add more props to the codemirror editor to ease migration from older version #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarDamkjaer
commented
Feb 22, 2024
| fontFamily: 'Fira Code, Menlo, Monaco, Lucida Console, monospace', | ||
| height: '100%', |
There was a problem hiding this comment.
This change is so that consumers can set a minimum height via the className property and have the background color extend to the full height
OskarDamkjaer
changed the title
ncordon
reviewed
Apr 30, 2024
.changeset/afraid-beans-juggle.md
Outdated
| '@neo4j-cypher/react-codemirror': patch | ||
| --- | ||
|
|
||
| Adds more props the CypherEditor component |
There was a problem hiding this comment.
Typo: to the CyherEditor component?
ncordon
reviewed
Apr 30, 2024
| @@ -71,5 +71,10 @@ export class CypherEditorPage { | |||
| await this.page.getByText(queryChunk, { exact: true }).hover(); | |||
| await expect(this.page.locator('.cm-tooltip-hover').last()).toBeVisible(); | |||
| await expect(this.page.getByText(expectedMsg)).toBeVisible(); | |||
| // make the sure the tooltip closes | |||
| await this.page.mouse.move(0, 0); | |||
There was a problem hiding this comment.
Funnily enough I had to add this line in #202 🙈
ncordon
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty straightforward codemirror wiring & tests