Cut down on benchmarking metrics to improve build speeds #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarDamkjaer
changed the title
ncordon
reviewed
Jan 26, 2024
Comment on lines
21
to
35
| .add('simple - parse', function () { | ||
| parse(simpleQuery); | ||
| }) | ||
| .add('simple - highlight', function () { | ||
| parserWrapper.clearCache(); | ||
| applySyntaxColouring(simpleQuery); | ||
| }) | ||
| .add('simple - validate syntax', function () { | ||
| parserWrapper.clearCache(); | ||
| validateSyntax(simpleQuery, benchmarkingMediumSizeSchema); | ||
| }) | ||
| .add('simple - autocomplete next statement', function () { | ||
| parserWrapper.clearCache(); | ||
| autocomplete(simpleQuery, benchmarkingMediumSizeSchema); | ||
| }) |
There was a problem hiding this comment.
Why are we removing benchmarks? Wouldn't it be better to leave them but just run them on merge to main?
There was a problem hiding this comment.
I was in the "reduce gh minute" mindset, so I removed some that didn't feel like they were super impactful, to see if the build got noticeably faster. But you're right, I think we're better off keeping them - i added them back now
ncordon
approved these changes
Jan 29, 2024
ncordon
pushed a commit
that referenced
this pull request
Feb 5, 2024
* cut down on bench tests to make the job faster * don't run on PRs * keep benchmarks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's set something up in grafana for alerts, rather than build twice on the PR itself 👍