Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct calls to bit64 S3 methods #23

Open
MichaelChirico opened this issue Jan 31, 2025 · 0 comments
Open

Direct calls to bit64 S3 methods #23

MichaelChirico opened this issue Jan 31, 2025 · 0 comments

Comments

@MichaelChirico
Copy link

MichaelChirico commented Jan 31, 2025

Here are direct calls to S3 methods:

bit64::as.character.integer64(diag_exp_sets()$exp_set_id)

input <- bit64::as.integer64.character(input$filter_exps)

https://github.com/nebiolabs/uncleShiny/blob/825abd762e2fc3d93fb076b328d03f703d7d18eb/R/mod_dbQuery.R#L135https://github.com/nebiolabs/uncleShiny/blob/825abd762e2fc3d93fb076b328d03f703d7d18eb/R/mod_scatterPlots.R#L323
purrr::map_chr(.x, bit64::as.character.integer64),

These will break in the future when they are un-exported -- prefer calling e.g. as.character() and letting S3 dispatch do its thing.

See r-lib/bit64#76

@MichaelChirico MichaelChirico changed the title Calls to as.character.integer64 Direct calls to bit64 S3 methods Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant