feat: add support for GQL document input #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is broken |
simoneb
changed the title
simoneb
reviewed
Jan 18, 2024
| ) | ||
| } | ||
| const queryString = stringifyDocumentNode(query) | ||
| const operationName = extractOperationName(query) ?? initialOpts.operationName |
There was a problem hiding this comment.
is this logic correct? if you provide an operation name explicitly, shouldn't it have more priority than the one we infer from the query? unless I'm reading this wrong
There was a problem hiding this comment.
Corrected this.
simoneb
reviewed
Jan 18, 2024
luke88jones
force-pushed
the
document-node-support
branch
from
7480b33 to
52ae284
Compare
simoneb
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
DocumentNodeformatTypedDocumentNodeinferenceRelated issues
Resolves #1128
Checklist