-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Logger #10
Add Logger #10
Conversation
def set_logger(name: str) -> logging.Logger: | ||
logging.basicConfig(level=logging.INFO) | ||
logging.getLogger("near_lake_framework").setLevel(logging.INFO) | ||
missing_shard_filter = IgnoreFilter("doesn't exist") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the missing shard data something that gets backfilled in future data from near lake or skipped?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is that there was no data on the shared corresponding to the block. I think this filter can be removed if we downgrade this log to debug and set the lake log level to info. The filter is only a temporary solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created a PR here: frolvanya/near-lake-framework-py#16
We can leave this open and wait for the next version bump (if its approved) - then remove the whole filter class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the linter is happy https://github.com/near/gas-station-event-indexer/actions/runs/9305341947/job/25612033263, then we can merge. Seems like the best long term solution is improvements on the near-lake-framework-py repo.
This PR is split into two commits:
fetch_latest_block
function from here to there.