Shultz_Cole_Exercise_1_Submission

[ColeShultz]

No description provided.

[MFB1987]

#3: count frequency of variable list by checking if request or city is in empty list; 
#if yes, count value is added to list (+1); if not, request/city stored as new key with value of 1

#Code:
#define and check variables
request_type = 'Request Type'
city_name = 'City'
type_list = [d.get(request_type) for d in service_requests if request_type in d]

Fix:

[MFB1987]

#Code:
#define and check variables
request_type = 'Request Type'
city_name = 'City'
type_list = [d.get(request_type) for d in service_requests if request_type in d]
#print(type_list)
city_list = [d.get(city_name) for d in service_requests if city_name in d]

Fix: Filter out None values.

[MFB1987]

            frequency_dict[item] += 1
        else:
            frequency_dict[item] = 1
    return frequency_dict
    
result1 = count_frequency(type_list)
print(f'The type request count list is as follows: {result1}')

Issue: The function count_frequency is defined twice, once for request types and once for cities. The second definition overwrites the first, which is a logic error.

[MFB1987]

        else:
            frequency_dict[item] = 1
    return frequency_dict
    
result1 = count_frequency(type_list)
print(f'The type request count list is as follows: {result1}')

def count_frequency(city_list):

This overwrites the previous count_frequency function.

[MFB1987]

        if item in frequency_dict_2:
            frequency_dict_2[item] += 1
        else:
            frequency_dict_2[item] = 1
    return frequency_dict_2

result2 = count_frequency(city_list)
print(f'The number of requests for each city are as follows: {result2}')

Fix: Use a single generalized function that takes any list and returns a frequency dictionary.