Fixing some of the things from merge side for KNNVectorValues

Signed-off-by: Navneet Verma <navneev@amazon.com>
navneet1v · Aug 29, 2024 · ff8e7c4 · ff8e7c4
1 parent ab1ee62
commit ff8e7c4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/main/java/org/opensearch/knn/index/KNNSettings.java b/src/main/java/org/opensearch/knn/index/KNNSettings.java
@@ -277,7 +277,8 @@ public class KNNSettings {
     public static final Setting<Boolean> KNN_USE_LUCENE_VECTOR_FORMAT_ENABLED_SETTING = Setting.boolSetting(
         KNN_USE_LUCENE_VECTOR_FORMAT_ENABLED,
         false,
-        NodeScope
+        NodeScope,
+        Dynamic
     );
 
     /*

diff --git a/...ain/java/org/opensearch/knn/index/codec/KNN990Codec/NativeEngines990KnnVectorsWriter.java b/...ain/java/org/opensearch/knn/index/codec/KNN990Codec/NativeEngines990KnnVectorsWriter.java
@@ -76,6 +76,7 @@ public void flush(int maxDoc, final Sorter.DocMap sortMap) throws IOException {
         StopWatch stopWatch = new StopWatch();
         stopWatch.start();
         flatVectorsWriter.flush(maxDoc, sortMap);
+        flatVectorsWriter.finish();
         for (final NativeEngineFieldVectorsWriter<?> field : fields) {
             trainAndIndex(
                 field.getFieldInfo(),