Fixed the order of how vectors are transferred to JNI layer

Signed-off-by: Navneet Verma <navneev@amazon.com>
navneet1v · Mar 1, 2024 · b87ed7f · b87ed7f
1 parent d2e07c6
commit b87ed7f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/jni/src/nmslib_wrapper.cpp b/jni/src/nmslib_wrapper.cpp
@@ -283,6 +283,11 @@ void knn_jni::nmslib_wrapper::CreateIndex_With_Memory_Address(knn_jni::JNIUtilIn
                 topLevelPointer++;
             }
 
+//            for(int j = 0; j < dim ; j++) {
+//                std::cout<<floatArrayCpp[j]<<" ";
+//            }
+//            std::cout<<std::endl;
+
             memcpy(ptr, &floatArrayCpp, vectorSizeInBytes);
             //jniUtil->ReleaseFloatArrayElements(env, floatArrayJ, floatArrayCpp, JNI_ABORT);
             ptr += vectorSizeInBytes;

diff --git a/jni/src/org_opensearch_knn_jni_FaissService.cpp b/jni/src/org_opensearch_knn_jni_FaissService.cpp
@@ -144,7 +144,7 @@ JNIEXPORT jlong JNICALL Java_org_opensearch_knn_jni_FaissService_transferVectors
 
     int dim = jniUtil.GetInnerDimensionOf2dJavaFloatArray(env, vectorsJ);
     auto dataset = jniUtil.Convert2dJavaObjectArrayToCppFloatVector(env, vectorsJ, dim);
-    vect->insert(vect->begin(), dataset.begin(), dataset.end());
+    vect->insert(vect->end(), dataset.begin(), dataset.end());
 
     return (jlong) vect;
 }