Hent Altinn-tilganger via Fager sitt API #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjerga
requested changes
Jan 21, 2025
apps/altinn/src/main/kotlin/no/nav/helsearbeidsgiver/inntektsmelding/altinn/AltinnRiver.kt
Outdated
Show resolved
Hide resolved
apps/altinn/src/main/kotlin/no/nav/helsearbeidsgiver/inntektsmelding/altinn/AltinnRiver.kt
Outdated
Show resolved
Hide resolved
magnusae
commented
Jan 21, 2025
Comment on lines
-47
to
-48
| val maskinportenToken = TokenResponse("test_token", "Bearer", 3600, "test:test1") | ||
| val tokenResponse = maskinportenToken.toJson(TokenResponse.serializer()).toString() |
There was a problem hiding this comment.
Siden vi fjerner Maskinporten-integrasjonen vår, så tar vi også bort de tokengreiene her, samt noen maskinporten-miljøvariabler under. Denne testen er deaktivert pga. at "Mocking av RapidApplication fungerer ikke med siste versjon", noe jeg anser for utenfor scope å fikse i denne PRen.
bjerga
approved these changes
Jan 22, 2025
bjerga
reviewed
Jan 22, 2025
apps/altinn/gradle.properties
Outdated
| @@ -1,4 +1,2 @@ | |||
| altinnClientVersion=0.4.0 | |||
| maskinportenClientVersion=0.1.9 | |||
| altinnClientVersion=0.5.0-SNAPSHOT | |||
There was a problem hiding this comment.
Neida, jeg ville bare teste denne (navikt/helsearbeidsgiver-altinn-client#15) og se at den logger at den henter Altinn-tilganger i dev, før jeg lagde en ny release i Altinn-clienten vår 👍 Lover å huske og endre til neste versjon (1.0.0 ⬆️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bakgrunn
Vi ønsker å gå over til Fager sitt API for henting av Altinn-tilganger for å gjøre fremtidig flytting av tilganger fra Altinn 2 til Altinn 3 enklere. (Fager sitt API henter og syr sammen tilganger fra både Altinn 2 og Altinn 3.)
Løsning
Bruk ny versjon av AltinnClient (
Altinn3M2MClient), som henter rettigheter fra Fager sitt API ved hjelp av M2M-/Azure-token.