Logg maskert fødselsnummer kun til sikre logger #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnusae
commented
Jan 24, 2025
| logger.info(it) | ||
| sikkerLogger.info(it) | ||
| } | ||
| sikkerLogger.info("Henter Altinntilganger fra Fager sitt m2m-endepunkt for ${fnr.take(6)}XXXX") |
There was a problem hiding this comment.
Endrer sånn at vi like greit tar med hele fødselsdatoen, nå som dette går til sikre logger.
mortenbyhring
approved these changes
Jan 24, 2025
b162214
approved these changes
Jan 24, 2025
magnusae
added a commit
to navikt/helsearbeidsgiver-inntektsmelding
that referenced
this pull request
Jan 24, 2025
For å få med denne endringen: navikt/helsearbeidsgiver-altinn-client#16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jeg ble litt forvirret av at denne loggen i den gamle Altinn-klienten ble logget til vanlige logger (
logger.debug()) og at den allerede var maskert (som fikk meg til å tenke at den var grei for vanlige logger).Vi har kommet frem til at det ryddigste er å kun ha dette i
sikkerLogger.