Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endre oppsett for spørsmål om kontantstøtte #2753

Conversation

EndreHM
Copy link
Contributor

@EndreHM EndreHM commented Jan 16, 2025

Favro

Kun endring på kontantstøtte for å ha mulighet for å ha begrunnelse. Tar endringer på tillegstønad i egen pr

@EndreHM EndreHM requested a review from a team as a code owner January 16, 2025 09:21
@ma10s
Copy link
Contributor

ma10s commented Jan 17, 2025

Sjekk gjerne om vi trenger legge til noe i blankett

@@ -92,6 +92,7 @@ class VedtakHistorikkService(
begrunnelse = null,
perioder = perioder,
perioderKontantstøtte = mapUtgifterBarnetilsyn(historikk, fra) { it.kontantstøtte },
kontantstøtteBegrunnelse = null,
Copy link
Contributor

@ma10s ma10s Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ikke nødvendligvis en kommentar til endring, men kanskje vi kunne brukt noe annet enn InnvilgelseBarnetilsyn her? Burde dette vært et SammenslåttPeriodehistorikkBarnetilsyn klasse eller liknende??? Ny legacy oppgave?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hvorfor blir kontantstøtteBegrunnelse automatisk satt til null her egentlig? Og hvorfor skjer det samme med begrunnelse?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vi har ikke disse begrunnelsene i vedtakshistorikken - all den tid vi har et AndelHistorikkDto-objekt

Copy link
Contributor

@ma10s ma10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supert! Ser bra ut - fint om du sjekker blankett før vi går i prod.

@EndreHM EndreHM merged commit 1e1ce03 into main Feb 3, 2025
6 checks passed
@EndreHM EndreHM deleted the endre-oppsett-for-spørsmål-om-tilleggsstønader-og-kontantstøtte branch February 3, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants