-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable streaming by default #770
base: main
Are you sure you want to change the base?
Conversation
mtmk
commented
Jul 7, 2024
•
edited
Loading
edited
- Disable streaming by default since it's deprecated and building with it on Windows is not easy
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #770 +/- ##
==========================================
+ Coverage 68.71% 70.36% +1.65%
==========================================
Files 39 47 +8
Lines 15207 15410 +203
Branches 3143 3161 +18
==========================================
+ Hits 10449 10844 +395
+ Misses 1700 1524 -176
+ Partials 3058 3042 -16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, but I wonder if we need the auto-retry?
# Conflicts: # .github/workflows/on-pr-debug.yml