Add SitePrism::FrozenInTimeError to catch frozen time issues #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luke-hill
requested changes
Apr 26, 2019
lib/site_prism/waiter.rb
Outdated
|
|
||
| private | ||
|
|
||
| def check_for_time_stopped! |
There was a problem hiding this comment.
this needs to take the start_time as an argument I think. EDIT: This also needs to be a class method
| @@ -26,5 +26,22 @@ | |||
|
|
|||
| expect(duration).to be_within(0.1).of(timeout) | |||
| end | |||
|
|
|||
| context 'when time is frozen' do | |||
| before do | |||
There was a problem hiding this comment.
this could probably be simplified to allow(Time).to receive(:now).and_return { Time.new(2019,4,25) } to save you having to open the class up - Might be a bit shorter as well
|
@luke-hill Alright, fixed all that up, and tests are passing. Let me know if there's anything else needed here. |
luke-hill
approved these changes
Apr 26, 2019
|
Top stuff, well done on the quick turnaround too. Thanks for the contribution, it's greatly appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#388