Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could this be applied to local graphs too? #22

Open
oldjove opened this issue Feb 27, 2024 · 14 comments
Open

Could this be applied to local graphs too? #22

oldjove opened this issue Feb 27, 2024 · 14 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@oldjove
Copy link

oldjove commented Feb 27, 2024

Very nice plugin. Lots of potential. Personally I would find this very helpful to use on local graphs as well. Would that be possible to implement?

@natefrisch01
Copy link
Owner

It should work for local graphs... perhaps there's something else causing it to not work for you? How are your links formatted, what are your filenames, and are they in subfolders? Perhaps this is causing it to not work for local graph.

@natefrisch01
Copy link
Owner

image

@natefrisch01 natefrisch01 added the bug Something isn't working label Feb 27, 2024
@oldjove
Copy link
Author

oldjove commented Feb 27, 2024

Hmm, thanks. Let me investigate further ...

@oldjove oldjove closed this as completed Feb 27, 2024
@jsmm
Copy link

jsmm commented Feb 28, 2024

It doesn't work for me either. I have Dataview installed and linked files are in the same folder.

@natefrisch01
Copy link
Owner

Would you be willing to share a screenshot that shows your file structure and a local graph? Also, what OS are you using. It seems some people are having a hard time with local graph, but I havent been able to recreate the error.

@natefrisch01 natefrisch01 reopened this Feb 28, 2024
@jsmm
Copy link

jsmm commented Feb 28, 2024

I do have some folders, but I have tested this plugin for local graph with a note that doesn't have any direct link to notes in other folders. I am using macOS 14.3.1.

@natefrisch01
Copy link
Owner

Could you please give me example files that would recreate your error?

@jsmm
Copy link

jsmm commented Feb 28, 2024

Sure. Here they are. The link is in the first file.

Lu_ Angola.md
C_g- África.md

@natefrisch01
Copy link
Owner

So, I took a look at these, and I'm thinking it has to do with #7. The special characters are probably what's causing the issue. I don't understand why it would work in global view and not local, however.

@FancyBEAST
Copy link

FancyBEAST commented Mar 30, 2024

I also noticed this issue. But I noticed this only happens when I am not actively focused on the current note for which the local view is used.

Edit: Nvm even when note is focused it still doesn't work sometime. It works good when I have the link mentioned at the top of the note. But if it's in the middle or around the end of note the label doesn't show up

@natefrisch01
Copy link
Owner

natefrisch01 commented Apr 1, 2024

@FancyBEAST

Do you have other metadata before the metadata with the link as in #25 ?

@elvarb
Copy link

elvarb commented Apr 19, 2024

I tried a few things for this issue and it seems that the current method works like this

  • Iterate key/values in the front matter and then following inline key/values in the document

The issues is that the method expects all key/values to be a key followed by a markdown link. If it sees anything else the methods breaks and stops parsing.

What causes confusion is that some frontmatter types seem to be ok and not cause the parsing to stop. This is because some frontmatter types are multi value fields and are therefore stored differently in the source.

For example this does not break the process

---
aliases:
  - graphlinktype
tags:
  - one
  - two
related:: [[graph]]
---

But this does break the process

---
created: 2024-04-19
aliases:
  - graphlinktype
tags:
  - one
  - two
related:: [[graph]]
---

This also breaks the process with regarding inline key/values

---
aliases:
  - graphlinktype
tags:
  - one
  - two
related:: [[graph]]
---

type::Guide

parent:: [[Obsidian Plugins]]

@natefrisch01 natefrisch01 added the duplicate This issue or pull request already exists label Aug 3, 2024
@jesvtb
Copy link

jesvtb commented Dec 28, 2024

I am having the same issue. I have a lot of notes with date property and these notes can't seem to load the link in graph.

Is this getting fixed?

Thanks for the plugin btw!

@the-a-man-006
Copy link

Same. Works perfectly in global graph view, but not in local graph...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

7 participants