Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 [Magic Number Removal] - CBC Padding parameters in AOS and TM #422

Open
dccutrig opened this issue Mar 17, 2025 · 1 comment
Open
Assignees

Comments

@dccutrig
Copy link
Contributor

Summary

Look at and review the correct bounds for CBC Padding parameters in AOS and TM, then set thsese as #defines instead of magic numbers (e.g. 16)

Don't blanket use 16 - we need to understand the actual limitations in conjunction with the telemetry frames. (e.g. what happens if we aren't using idle frames... does CBC auto-pad out the whole frame?)

Use Case

Will be needed in future for telemetry support

@dccutrig
Copy link
Contributor Author

Examine:
if (*len_ingest < tc_sdls_processed_frame->tc_header.fl + 1) // Specified frame length larger than provided frame!

as well in crypto_tc.c - are we able to make it a != to tighten it up, or does this negatively affect CBC processing?

@Donnie-Ice Donnie-Ice self-assigned this Mar 18, 2025
Donnie-Ice added a commit that referenced this issue Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants