Fix bug in make_fake_toas_fromtim
#1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a new test, but it isn't the fastest. It does make things a bit slower. At some point we might want a simpler WB test data-set. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1698 +/- ##
==========================================
+ Coverage 68.41% 68.42% +0.01%
==========================================
Files 104 104
Lines 24339 24339
Branches 4346 4346
==========================================
+ Hits 16651 16654 +3
+ Misses 6600 6598 -2
+ Partials 1088 1087 -1 ☔ View full report in Codecov by Sentry. |
dlakaplan
added
the
awaiting review
|
Looks good. Shall I merge this? |
|
Yes, please do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1697