Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Observatory.get() #1769

Closed
paulray opened this issue May 22, 2024 · 1 comment · Fixed by #1763
Closed

Bug in Observatory.get() #1769

paulray opened this issue May 22, 2024 · 1 comment · Fixed by #1763

Comments

@paulray
Copy link
Member

paulray commented May 22, 2024

I think there is a bug in the class method Observatory.get(). It explicitly adds the new Observatory object to the registry with this line:

cls._register(obs, name)

But, it should already be added to the registry from the __init__() method, which calls the class method _register().
So I think this line should be deleted.

@paulray
Copy link
Member Author

paulray commented May 22, 2024

Fixed in #1763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant