Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconcile new and old GSARaman classes #86

Open
dadamsncsa opened this issue Jun 25, 2020 · 1 comment
Open

Reconcile new and old GSARaman classes #86

dadamsncsa opened this issue Jun 25, 2020 · 1 comment
Assignees
@aagamrshah
Labels
task: other

Comments

@dadamsncsa
Copy link
Member

Description

The current code base contains a ne and old version of the main GSARaman class in 2 files:

Proposed Solution

  • Consolidate the new code into the file named gsaraman.py and remove gsaraman-new.py.
  • Resolve sub-module dependency issues (to gresq) as needed. Note gresq can be pinned to an older snapshot of master if absolutely needed. Ideally a new gsaraman.py can be updated that resolves all gresq compatibility issues and consolidates the new code.
@dadamsncsa
Copy link
Member Author

@AagamShah97 We need to follow up on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aagamrshah aagamrshah

Labels
task: other
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dadamsncsa @aagamrshah