Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [sc-26283] Enhance namegraph-sdk #596

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Y3drk
Copy link
Collaborator

@Y3drk Y3drk commented Feb 4, 2025

Planned changes based on nameguard and nameai SDKs:

  • Write unit tests
  • Update README with Contact us and License sections (later added examples of methods that were previously lacking)
  • Provide detailed docs in index.ts and utils.ts (synchronized with namegraph python package amap)
  • Code changes:
    • Move default variables to index.ts (TO DISCUSS: necessity of changing loads of imports throughout the entire repository → not worth it, left as they were)
    • Change some of the type structures to interface in accordance to other SDKs (Responses as interfaces, other remains types)
    • Reduce the amount of magic numbers:
      • Create defaults for all use cases that appear in the code at least twice
      • Consider singular occurrences and situations when default values are overridden (TO DISCUSS).

Copy link

changeset-bot bot commented Feb 4, 2025

⚠️ No Changeset found

Latest commit: df64466

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples.nameguard.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 10:42am
nameai.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 10:42am
namegraph.dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 10:42am
nameguard.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 10:42am
namehashlabs.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 10:42am
namekit.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 10:42am
storybook.namekit.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 10:42am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
nameai.dev ⬜️ Skipped (Inspect) Feb 7, 2025 10:42am

@Y3drk Y3drk marked this pull request as draft February 4, 2025 12:57
@vercel vercel bot temporarily deployed to Preview – storybook.namekit.io February 4, 2025 13:44 Inactive
@vercel vercel bot temporarily deployed to Preview – nameai.dev February 4, 2025 13:44 Inactive
@vercel vercel bot temporarily deployed to Preview – examples.nameguard.io February 4, 2025 13:44 Inactive
@vercel vercel bot temporarily deployed to Preview – nameguard.io February 4, 2025 13:44 Inactive
@vercel vercel bot temporarily deployed to Preview – namehashlabs.org February 4, 2025 13:44 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook.namekit.io February 4, 2025 14:05 Inactive
@vercel vercel bot temporarily deployed to Preview – nameai.dev February 4, 2025 14:05 Inactive
@vercel vercel bot temporarily deployed to Preview – nameguard.io February 4, 2025 14:05 Inactive
@vercel vercel bot temporarily deployed to Preview – examples.nameguard.io February 4, 2025 14:05 Inactive
@vercel vercel bot temporarily deployed to Preview – namehashlabs.org February 4, 2025 14:05 Inactive
@vercel vercel bot temporarily deployed to Preview – nameguard.io February 5, 2025 15:49 Inactive
@vercel vercel bot temporarily deployed to Preview – namehashlabs.org February 5, 2025 15:49 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook.namekit.io February 6, 2025 11:57 Inactive
@vercel vercel bot temporarily deployed to Preview – namehashlabs.org February 6, 2025 11:57 Inactive
@vercel vercel bot temporarily deployed to Preview – examples.nameguard.io February 6, 2025 11:57 Inactive
@vercel vercel bot temporarily deployed to Preview – nameguard.io February 6, 2025 11:57 Inactive
@vercel vercel bot temporarily deployed to Preview – nameai.io February 6, 2025 11:57 Inactive
@Y3drk Y3drk marked this pull request as ready for review February 6, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant