Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notrab/sc 26233/priority refinements for nameai app launch #582

Merged

Conversation

notrab
Copy link
Member

@notrab notrab commented Jan 29, 2025

No description provided.

Copy link

changeset-bot bot commented Jan 29, 2025

🦋 Changeset detected

Latest commit: 0d3314a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@namehash/namekit-react Minor
@namehash/nameguard-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ensnode.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2025 2:32pm
examples.nameguard.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2025 2:32pm
nameai.dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2025 2:32pm
namegraph.dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2025 2:32pm
nameguard.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2025 2:32pm
namehashlabs.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2025 2:32pm
namekit.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2025 2:32pm
storybook.namekit.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2025 2:32pm

@Y3drk
Copy link
Collaborator

Y3drk commented Jan 30, 2025

Hi @notrab!

I've spotted this throughout several of our pages and wonder if that's done on purpose or is it a bug/misshap.

Namely in the footer, in the Made with <3 by NameHash Labs the hyperlink always leads to itself (ex. to namegraph.dev on namegraph.dev) instead of to namehashlabs.org.

It also occurs for nameai.dev.

namehash_footer_bug

I see that you perform fixes before launch so I though I'll let you know, just in case.

@vercel vercel bot temporarily deployed to Preview – namehashlabs.org January 30, 2025 09:03 Inactive
@vercel vercel bot temporarily deployed to Preview – nameguard.io January 30, 2025 09:03 Inactive
@vercel vercel bot temporarily deployed to Preview – namegraph.dev January 30, 2025 09:03 Inactive
@vercel vercel bot temporarily deployed to Preview – examples.nameguard.io January 30, 2025 09:03 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook.namekit.io January 30, 2025 09:03 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook.namekit.io January 30, 2025 09:04 Inactive
Copy link
Member

@lightwalker-eth lightwalker-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@notrab Hey this looks awesome! Great work 🚀 Just 1 small suggestion but can be done in a separate PR 👍

const [isAtStart, setIsAtStart] = useState<boolean>(true);
const [isAtEnd, setIsAtEnd] = useState<boolean>(false);

const examples = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working great! Suggest that we make it so that the list of examples can be dynamically injected in depending on the example app. For now let's use the same examples across both example apps. But I'll follow up later with a request to use some different examples on the AI Sort app. The examples here are better optimized for the Tokenization app.

@notrab
Copy link
Member Author

notrab commented Jan 31, 2025

Hi @notrab!

I've spotted this throughout several of our pages and wonder if that's done on purpose or is it a bug/misshap.

Namely in the footer, in the Made with <3 by NameHash Labs the hyperlink always leads to itself (ex. to namegraph.dev on namegraph.dev) instead of to namehashlabs.org.

It also occurs for nameai.dev.

namehash_footer_bug

I see that you perform fixes before launch so I though I'll let you know, just in case.

Hey @Y3drk

Thanks for noticing that. I copied this footer from another app layout, so I assume this issue is on other apps too. I've pushed a fix to the nameai.dev footer. Hopefully we can create a shared component for these at some point.

@lightwalker-eth
Copy link
Member

@notrab I agree! @eduramme has an open goal to implement that unified footer component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants