-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notrab/sc 26233/priority refinements for nameai app launch #582
Notrab/sc 26233/priority refinements for nameai app launch #582
Conversation
🦋 Changeset detectedLatest commit: 0d3314a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi @notrab! I've spotted this throughout several of our pages and wonder if that's done on purpose or is it a bug/misshap. Namely in the footer, in the It also occurs for nameai.dev. I see that you perform fixes before launch so I though I'll let you know, just in case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@notrab Hey this looks awesome! Great work 🚀 Just 1 small suggestion but can be done in a separate PR 👍
const [isAtStart, setIsAtStart] = useState<boolean>(true); | ||
const [isAtEnd, setIsAtEnd] = useState<boolean>(false); | ||
|
||
const examples = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working great! Suggest that we make it so that the list of examples can be dynamically injected in depending on the example app. For now let's use the same examples across both example apps. But I'll follow up later with a request to use some different examples on the AI Sort app. The examples here are better optimized for the Tokenization app.
Hey @Y3drk Thanks for noticing that. I copied this footer from another app layout, so I assume this issue is on other apps too. I've pushed a fix to the |
No description provided.