feat: include domain logics into ens-utils
#341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, DomainName, DomainCard, etc.)
FrancoAguzzi
requested review from
djstrong,
Carbon225,
notrab,
lightwalker-eth,
BanaSeba and
eduramme
as code owners
🦋 Changeset detectedLatest commit: 1263f48 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
FrancoAguzzi
changed the title
ens-utils
lightwalker-eth
requested changes
Jul 30, 2024
There was a problem hiding this comment.
@FrancoAguzzi This is a much improved PR strategy 👍 Reviewed and shared feedback. Let's work to make this PR really beautiful.
…/include-domain-logics-into-ens-utils
FrancoAguzzi
force-pushed
the
francoaguzzi/sc-25546/include-domain-logics-into-ens-utils
branch
from
1d43401 to
1263f48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.