restructure files #260
restructure files #260
Conversation
notrab
requested review from
djstrong,
Carbon225,
Byczong and
lightwalker-eth
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
@notrab Hey from a code-review perspective looks good. Before we merge this though appreciate if you could action the following:
- I see there's a build error for the NameGuard website. https://vercel.com/namehash/nameguard-website/Et8sDahPi1r5FwnUwvweDPgW48LY
- Create a PR on the readme in ens-utils so that the readme is basically just a link to where the new home for that library has moved.
- Same for the namekit-archive repo. If you could update the readme there to basically just document the mappings from code in that repo to code in the new namekit monorepo.
Nice work 👍
There was a problem hiding this comment.
Can you please confirm the plan for how this example app will (continue to) be automatically deployed to Vercel? Let's ensure the CI/CD works well for this example app. This will be important for some of the next steps that Jakub is advancing.
I'm fine if this is something we need to follow up with after we merge this PR. If this is true, can you please make a note to be sure we follow up with this? Appreciate your advice.
There was a problem hiding this comment.
I don't think this was ever automatically deployed due to some restrictions of Vercel, but I will double check.
| Licensed under the MIT License, Copyright © 2023-present [NameHash Labs](https://namehashlabs.org). | ||
|
|
||
| See [LICENSE](./LICENSE) for more information. | ||
| # Namekit |
There was a problem hiding this comment.
@notrab As a temporary step in the new root-level NameKit readme, could you please include a link to the retained / renamed "nameguard.md"? The goal of this suggestion is to retain some better discoverability for where to learn more about getting started with NameGuard. Appreciate your advice.
There was a problem hiding this comment.
I planned to have a list of all the packages, internal packages and apps with links to their folders. I'll do that probably later today.
There was a problem hiding this comment.
Awesome, thank you @lightwalker-eth
The big refactor...
Not in this PR
websiterenameREADMEmove (will move once @FrancoAguzzi merges his changes and our PRs settle this week)