test: Add coverage for token exchange #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomi
previously approved these changes
Nov 28, 2024
| } | ||
| } | ||
|
|
||
| func TestFetchGrantTokenRetry(t *testing.T) { |
There was a problem hiding this comment.
Would it be possible to test also failing connection to the server? Feel free to ignore if gets to cumbersome
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
tomi
approved these changes
Nov 28, 2024
| @@ -29,18 +29,18 @@ func TestCheckUntilBrokerReadyHappyPath(t *testing.T) { | |||
| for _, tt := range tests { | |||
| t.Run(tt.name, func(t *testing.T) { | |||
| requestCount := 0 | |||
| server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | |||
| srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | |||
There was a problem hiding this comment.
Personally I'm not a big fan of abbreviating names too much. There's plenty of room in the world for characters to have clear and explicit names :D
There was a problem hiding this comment.
Agree! Following this as I think it's the Go style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/n8n/issue/PAY-2247/write-tests-for-launcher